Skip to content

(v8.x backport) crypto: reuse variable instead of reevaluation #19114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

(v8.x backport) crypto: reuse variable instead of reevaluation #19114

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Mar 4, 2018

Backport of #17735 to v8.x.

@tniessen
crypto: reuse variable instead of reevaluation
2250b3c 
PR-URL: nodejs#17735
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. v8.x labels Mar 4, 2018
@tniessen tniessen mentioned this pull request Mar 4, 2018
Closed
2 tasks
@gibfahn gibfahn self-assigned this Mar 4, 2018
@gibfahn
Copy link
Member

gibfahn commented Mar 20, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13764/

@MylesBorins
Copy link
Contributor

potentially related failure in debian 8 https://ci.nodejs.org/job/node-test-commit-linux/17205/nodes=debian8-x86/console

09:37:16 not ok 1028 parallel/test-https-client-resume
09:37:16   ---
09:37:16   duration_ms: 0.512
09:37:16   severity: fail
09:37:16   stack: |-

@tniessen
Copy link
Member Author

This PR should not affect TLS tests. I started two more CIs, the first failed parallel/test-tls-ca-concat and the second passed without problems. There might be some flakiness with TLS tests on this branch, but it is unlikely to be caused by this change.

MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
@tniessen @MylesBorins
crypto: reuse variable instead of reevaluation
b43a59c 
Backport-PR-URL: #19114
PR-URL: #17735
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins
Copy link
Contributor

Thanks for the heads up

landed in b43a59c

MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@tniessen @MylesBorins
crypto: reuse variable instead of reevaluation
44cb0d3 
Backport-PR-URL: #19114
PR-URL: #17735
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@tniessen @MylesBorins
crypto: reuse variable instead of reevaluation
16bf5fe 
Backport-PR-URL: #19114
PR-URL: #17735
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

+1 more reviewer

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@gibfahn gibfahn

Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tniessen @gibfahn @MylesBorins @lpinca @nodejs-github-bot